fix(anchor-sdk): add missing LICENSE/README, align version for first publish - #1019
Merged
Conversation
…publish package.json declared "files": ["dist", "README.md", "LICENSE"] but neither file existed on disk - the next release tag would have published this package with no license text. Added the canonical repo-wide MIT LICENSE (identical text to every other package) and a real README documenting the SEP-1/10/12/24/31 clients this package actually implements. Also aligned version 0.2.0 -> 0.1.0: this package has never been published, so 0.2.0 implied a 0.1.0 predecessor that never existed. Matches the rest of the workspace's first-publish convention.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package.jsondeclared"files": ["dist", "README.md", "LICENSE"]but neither file existed on disk - the nextv*release tag would have published this package with no license text (release.yml globs all ofpackages/*).LICENSE(identical text to every other package) and a realREADME.mddocumenting the SEP-1/10/12/24/31 clients this package actually implements.0.2.0->0.1.0: this package has never been published, so0.2.0implied a0.1.0predecessor that never existed. Matches the rest of the workspace's first-publish convention.Test plan
pnpm --filter @orbital-stellar/anchor-sdk buildcleanpnpm --filter @orbital-stellar/anchor-sdk test- 72/72 passingnpm pack --dry-runconfirmsdist/,README.md,LICENSEall included in the tarball